Add timeout section to streaming wiki #13415
Conversation
|
|
Hi @WillSmithTE, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
In my opinion this timeout should be longer by default, something like 30 seconds |
docs/how-to/suspense.md
Outdated
|
|
||
| ## Timeouts | ||
|
|
||
| By default, loaders and actions reject any outstanding promises after 4950ms. You can control this by exporting a `streamTimeout` numerical value from your entry.server.tsx. |
There was a problem hiding this comment.
| By default, loaders and actions reject any outstanding promises after 4950ms. You can control this by exporting a `streamTimeout` numerical value from your entry.server.tsx. | |
| By default, loaders and actions reject any outstanding promises after 4950ms. You can control this by exporting a `streamTimeout` numerical value from your `entry.server.tsx`: |
docs/how-to/suspense.md
Outdated
|
|
||
| By default, loaders and actions reject any outstanding promises after 4950ms. You can control this by exporting a `streamTimeout` numerical value from your entry.server.tsx. | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Can we annotate this triple-backtick with ts filename=entry.server.tsx? I don't think I can do it in a suggestion due to the nested backticks...
There was a problem hiding this comment.
sure thing, done
Mostly copied from the remix docs: https://remix.run/docs/en/main/guides/single-fetch#streaming-timeout
Discussed in an issue: #12467